Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133262 / 25.04 / Fix more strict null issues #11240

Merged
merged 4 commits into from
Dec 28, 2024
Merged

NAS-133262 / 25.04 / Fix more strict null issues #11240

merged 4 commits into from
Dec 28, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 25, 2024

Testing:

Code review.

@undsoft undsoft requested a review from a team as a code owner December 25, 2024 21:35
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team December 25, 2024 21:35
@bugclerk bugclerk changed the title NAS-133262: Fix more strict null issues NAS-133262 / 25.04 / Fix more strict null issues Dec 25, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133262

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.95652% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.51%. Comparing base (35832d8) to head (b5d591f).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ivilege/privilege-list/privilege-list.component.ts 33.33% 2 Missing ⚠️
...options-section/other-options-section.component.ts 85.71% 1 Missing ⚠️
...missions/utils/nfs-ace-to-permission-item.utils.ts 75.00% 1 Missing ⚠️
src/app/pages/jobs/jobs-list.component.ts 0.00% 1 Missing ⚠️
.../iscsi/target/all-targets/all-targets.component.ts 0.00% 1 Missing ⚠️
...pages/storage/modules/devices/devices.component.ts 0.00% 1 Missing ⚠️
...ystem/alert-settings2/alert-settings2.component.ts 0.00% 1 Missing ⚠️
.../enclosure-page/pools-view/pools-view.component.ts 0.00% 1 Missing ⚠️
...instance-edit-form/instance-edit-form.component.ts 0.00% 1 Missing ⚠️
...rtualization/stores/virtualization-config.store.ts 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11240   +/-   ##
=======================================
  Coverage   82.50%   82.51%           
=======================================
  Files        1655     1655           
  Lines       58943    58950    +7     
  Branches     6091     6108   +17     
=======================================
+ Hits        48633    48640    +7     
  Misses      10310    10310

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft
NAS-133262: Fix more strict null issues
1ee9936
@undsoft
Merge branch 'master' of github.com:truenas/webui into NAS-133262
b5d591f 
# Conflicts:
#	src/assets/i18n/ko.json
#	src/assets/i18n/nl.json
#	src/assets/i18n/zh-hans.json
#	src/assets/i18n/zh-hant.json
AlexKarpov98
AlexKarpov98 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(LooksGood)!;

@undsoft undsoft merged commit 1aaecd8 into master Dec 28, 2024
11 checks passed
@undsoft undsoft deleted the NAS-133262 branch December 28, 2024 02:05
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@undsoft @bugclerk @AlexKarpov98